wizbots / labtab

0 stars 0 forks source link

Add new field that allows selecting mentors from dropdown list #141

Open internetmosquito opened 4 years ago

internetmosquito commented 4 years ago

We will need to add a new filter that allows selecting one of the mentors from the whole list when selecting programs so basically any mentor can check programs and roster from other mentors.

Call this field "mentor" and should be a drop-down with the names (first name + last name) of each mentor. We're currently creating new endpoint that will return this data, along with the ID for each mentor, that you would need later to do the filtering.

kapoorutd commented 4 years ago

Can you please share the end point for the same? Also, do we have any mockup or sketch to demo what we would like to do.

internetmosquito commented 4 years ago

@kapoorutd the endpoint is being implemented and as for mockup nope, but let me work on one

kapoorutd commented 4 years ago

@internetmosquito Can you please share the end point if you have it handy.

internetmosquito commented 4 years ago

@kapoorutd here's the mockup

Screenshot_20200208-001845_LabTab

So basicallly we need the Mentor filed which will displlay all mentors and has an option to select All of them

Also the TODAY, WEEK will need to filter based on selected filters, not sure if we were doing that already?

kapoorutd commented 4 years ago

@internetmosquito Can you please provide login credentials for testing environment. As previous provided credentials are not working .

Email: judy@wizbots.com password: robotics

api response : 403, [text={"error": "Provided password or username are invalid"}\n]

Thanks

internetmosquito commented 4 years ago

@kapoorutd you can use Joshua's as Judy's is deactivated since she no longer works in wizbots. Same password, email joshua@wizbots.com

As for endpoint, couple comments, to get the whole list of mentors you'll need to hit

GET https://test.wizbots.com/api/mentors/

That will get you the whole list of mentors with ID, first name, last name

And for a specific mentor https://test.wizbots.com/api/mentors/{mentodID}

So this changes a bit from what you had now...besides, this is not yet on staging will let you know when it's ready

internetmosquito commented 4 years ago

@kapoorutd I made a build for this to try in staging, you can find it here

https://www.dropbox.com/s/w50yc4xi7o808bz/labtab_v1.15.0_20200314_staging.apk?dl=0

In any case, this is far from working.

When I login and go to lab list I noticed that it says, "please select any mentor"

Screenshot_20200315-185326_LabTab

What's the rationale with that?? All mentors was selected so actually, it should show basically programs for all mentors, in this case, for year 2020. By default, please make the mentor field select the mentor that is logged in, so if Joshua logged in, it should be pre-selected when mentor goes to lab list.

Even worst, I went ahead and selected Joshua as mentor and then no matter what combination of values I tried, always get the "no data" message

Screenshot_20200315-184948_LabTab

Which in fact, ain't true...I logged in with joshua@wizbots.com in test.wizbots.com and I could see programs for Joshua with the same search criteria

Selection_350

Selection_351

So this is clearly not working as expected...I'm attaching the logs of my tests, keep in mind if you see v1.14.0 it's because I forgot to update the release number in build.graddle (that's corrected on the build I've shared earlier in this post)

1584296180469_logs.zip

internetmosquito commented 4 years ago

This ain't working as expected yet, when selecting All mentors in dropdown says "please select any mentor", also, the dropdown should be pre-filled with the logged mentor whenever the view is shown

kapoorutd commented 4 years ago

Hi Alejandro,

Please tell me what mentor_id i need to pass in filter api in case of All Mentors. There is a mentor_id for every mentor which we pass in filter api in order to get filtered data, what i need to pass in all mentor case or i need to leave it empty? please update on this

kapoorutd commented 4 years ago

Hi Alejandro,

I have fixed this issue, now by default current logged in mentor will be selected in mentor dropdown and all mentor will not show message to select any mentor instead it will show all the program or labs.

we will update you on the issue with generating signed apk on tomorrow.

internetmosquito commented 4 years ago

@kapoorutd please for the All mentors option simply don't provide any mentor, it should return programs for ALL mentors but you must pass the current year otherwise you will probably timeout since we don't have pagination for that endpoint yet and you will actually get ALL the programs, so please make sure you filter by year

kapoorutd commented 4 years ago

Hi Alejandro,

I have fixed the issue which was causing error message while generating signed apk. Take a pull from add_mentor branch and try generating signed apk, you should be able to generate apk now.

internetmosquito commented 4 years ago

testing