wizeline / project-lab

Proposal Hunt / Project Lab experimental repo
MIT License
5 stars 0 forks source link

Feat/looking for field-21- Implement the “Looking for” list in ProjectDetail page. #288

Closed leonardohervert closed 2 years ago

leonardohervert commented 2 years ago

What does this PR do?

Implement the "Looking for" field, to add the required or necessary disciplines in the project, this PR adds the schema, seeds.

Where should the reviewer start?

app/pages/projects/[projectId]/index.tsx app/disciplines/queries/getDisciplines.ts app/projects/components/ProjectForm.tsx app/projects/mutations/updateProject.ts app/projects/mutations/createProject.ts app/projects/mutations/deleteProject.ts

How should this be manually tested?

  1. In the home page create a new Proposal
  2. Fill the default fields and add more details
  3. Fill the new field of "Looking For" to add the disciplines that the project need
  4. Create the project, and you could see the disciplines under the skills area.

Screenshots

image

image

Checklist

Issue #21

jackbravo commented 2 years ago

And I would say we can just separate the seed, and make sure we are importing it on the main seed. But I would leave modifying the CI for a separate PR or task, since for now we will be able to run it manually on prod only once.

leonardohervert commented 2 years ago

I already create both files, please check if I am right

LuisTejedaS commented 2 years ago

@jackbravo @leonardohervert let's keep in mind that we should be aware of modifying CI/CD before the next prod release or not forget to seed manually once deployed. Otherwise, users may feel that the feature is either incomplete or buggy.