Closed alan-maldonado closed 7 years ago
@bobmazanec @vidalon Do we have any rules on how many reviewers we need to get a PR approved for this repo? I see quite a few PRs that have been waiting for quite a while now.
I defer to you and Bob to close them.
Vidal
On Mon, Dec 5, 2016 at 6:37 PM -0600, "Willebaldo Gómez" notifications@github.com wrote:
@bobmazanec @vidalon Do we have any rules on how many reviewers we need to get a PR approved for this repo? I see quite a few PRs that have been waiting for quite a while now.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
@vidalon Thanks
For what it's worth: https://github.com/wizeline/wize-docs/blob/master/CONTRIBUTING.md#please
merge a PR to master only when it appears that...
- the conversation has "died down" (e.g., no new comments for a few days)
- consensus has been reached
Ok, I will proceed with the merge.
Overview
I added some solutions for this problem in javascript. I believe we should have some solutions with different approaches. So, if we understand better different points of view, the better we can help our candidates.
Let me know your feedback. I added @Vidal because I know he likes to do this problem. Also, I remembered when you ask to me to solve it.