search

wizicer / UAPNetwork

wrapper for UAP protocol which is widely used in USSD channel of mobile service in china
6 stars 8 forks source link

some good changes for using framework in public #7

Open mbahmani opened 7 years ago

mbahmani commented 7 years ago

I try to change and update framework for using it by others more and more

wizicer commented 7 years ago

Thanks for your contribution, would look into it within a week. (as I'm working on another important project now)

mbahmani commented 7 years ago

OK, thanks a lot

wizicer commented 7 years ago

Really thanks for your contribution, however, for the changes in StringUtility.cs, I can't agree, they are against Open-close principle, and make these scenarios which need encoding other than UTF8 failed.

mbahmani commented 7 years ago

we are not in the same boat ,in StringUtility.cs you used ASCII code in every method, it is against OC principle too

wizicer commented 7 years ago

You are right, existing code had flaws, so let's fix it this time.