wizmo2 / zidoo-player

Home-assistant custom component and api wrapper for Zidoo Media Players
22 stars 4 forks source link

Cannot make it work with Z20 Pro #18

Open albaintor opened 9 months ago

albaintor commented 9 months ago

Hi,

I can successfully add the device after entering the IP address, it detects the model (Z20 Pro), but that's all : I can't control the device nor access to the library I have tried to enable or disable authentication with no luck. Is it a compatibility issue with the new models (2023) or something wrong on my side ? Thanks

wizmo2 commented 9 months ago

Can you enable debugging in the Integration settings and see what is in the logs image

albaintor commented 9 months ago

Hi, I have enabled logs and I get this error message : Logger: custom_components.zidoo.zidoorc Source: custom_components/zidoo/zidoorc.py:448 Integration: Zidoo (documentation, issues) First occurred: 6 janvier 2024 à 16:04:17 (19983 occurrences) Last logged: 10:34:22

Exception: get() takes 1 positional argument but 2 were given

wizmo2 commented 9 months ago

That's good, but I need a little more information if possible

Could you restart HA, then (after a few minutes) download the log file (SETTINGS/SYSTEM/LOGS/Download Full Log.

I need to see

For example: 2024-01-07 10:15:07.592 DEBUG (SyncWorker_3) [custom_components.zidoo.zidoorc] connected: {'status': 200, 'model': 'Z9X', 'i..

albaintor commented 9 months ago

Hi again, here it is home-assistant_2024-01-07T12-08-37.861Z.log

I can't see additional debug information except the get() exception on the REST request apparently

Thanks

wizmo2 commented 9 months ago

As you say, there is no additional information here. The error is from the standard python requests library, so I don't think it is a zidoo issue. It may be something to do with your home-assistant setup (requests still works in the platform I test with, but HA are pushing migration to the async verison aiohttp)

Can you confirm you used only the ip address when setting up the player (e.g. 192.168.1.20 not http://192.168.1.20 and not 192.168.20:80)

Can you let me know

It will be a couple of days, but I'll look at adding a beta version with some more diagnostics.

albaintor commented 9 months ago

I am using the latest version : 2024.1.2 but I had this issue with previous updates too. I have a Odroid N2+ setup with homeassistant blue. Thanks for investigating EDIT : yes I used the IP address with no http:// prefix

albaintor commented 8 months ago

Nevermind, this is not the cause : the problem comes from the requests.get which cause an "Exception: get() takes 1 positional argument but 2 were given". I am not a Python expert, it is unclear what causes this error

albaintor commented 8 months ago

I found the fix : the params argument needed to be named. Just add "params=" and it works now response = requests.get( url, params=params, cookies=self._cookies, timeout=timeout, headers=headers )

albaintor commented 8 months ago

I just made a pull request. I let you review it. Thank you

wizmo2 commented 8 months ago

Excellent. Thank you very much. Been travelling this week, was going to look at it this weekend.

wizmo2 commented 8 months ago

Should be fixed in v1.4.2 with #19. Thanks @albaintor