search

wizpanda / cordova-plugin-firebase-lib

This repository is moving & merging to https://github.com/wizpanda/cordova-plugin-firebase-lib to avoid confusion to developers.
https://www.wizpanda.com/
MIT License
68 stars 38 forks source link

Fix breaking changes released by Google Firebase on Jun 17, 2019 #13

Closed sagrawal31 closed 5 years ago

sagrawal31 commented 5 years ago

On Jun 17, 2019, Google released some breaking changes:

image

Now, the first necessary change we need to make is:

Upgrade com.android.tools.build:gradle to v3.2.1 or later.

Now as per Android's gradle-plugin: to support a minimum of v3.2.1, we need to use Gradle 4.6:

image

But the cordova-android<=7.1.4 uses Gradle 4.1 so we need to upgrade the cordova-android to a minimum of v8.0.0 as Gradle has been upgraded to Gradle 4.10.1 https://github.com/apache/cordova-android/blob/rel/8.0.0/RELEASENOTES.md#800-feb-13-2019

So cordova-android >= 8.0.0 is required on this plugin now.

Although, you can upgrade the Gradle manually in your existing cordova-android 7.x versions but that will require many manual changes.

This PR support the latest builds shipped by Firebase.

sagrawal31 commented 5 years ago

Keeping it open for a few days for comments.

sagrawal31 commented 5 years ago

This PR is still in thought whether we want to really use the latest dependencies from Firebase which will actually require cordova-android to be upgraded to 8.0.0.

If we still want to keep support for cordova-android 7.x then we might need to compromise on Firebase dependencies by not using the latest releases as mentioned here.

So we are calling for a vote to keep support for cordova-android 7.x or not. Please react with 👍 to keep support for cordova-android 7.x and react with 👎 to drop support for cordova-android 7.x and merge & release PR.

maximilianloy commented 5 years ago

I think the best way to move forward would be creating a 3.x release first, with support for Cordova-android 7.x and the libraries fixed via plugin.xml to the older firebase release (as noted here). After that merge this PR and create 4.x release.

sagrawal31 commented 5 years ago

Yes @maximilianloy I'm doing the same.

sagrawal31 commented 5 years ago

Released v3.3.0 to support cordova-android 7.x.x. https://github.com/wizpanda/cordova-plugin-firebase-lib/pull/14#issuecomment-503499409

sagrawal31 commented 5 years ago

v4.0.0 was released which supports cordova-android 8.0.0 and fixes this issue because of breaking changes released by Google Firebase on Jun 17, 2019.

k8s-ap commented 5 years ago

v4.0.0 was released which supports cordova-android 8.0.0 and fixes this issue because of breaking changes released by Google Firebase on Jun 17, 2019.

I made it work after 1 week of learning in cordova with firebase. Thanks for sharing your knowledge!

sagrawal31 commented 5 years ago

Great! @DivingIoT did you used this plugin or something else?

k8s-ap commented 5 years ago

Great! @DivingIoT did you used this plugin or something else?

So far I only use that plugin