wizpanda / cordova-plugin-firebase-lib

This repository is moving & merging to https://github.com/wizpanda/cordova-plugin-firebase-lib to avoid confusion to developers.
https://www.wizpanda.com/
MIT License
68 stars 39 forks source link

ios build fails if 'name' field has cyrillic letters in config.xml #32

Closed Birowsky closed 5 years ago

Birowsky commented 5 years ago

If in config.xml you set the name tag to something like <name>кромид</name>, running cordova build ios will fail with:

ld: framework not found Pods_______

Here's a minimal example: config.xml:

<?xml version='1.0' encoding='utf-8'?>
<widget id="com.gotaguyapp" version="1.0.0" xmlns="http://www.w3.org/ns/widgets" xmlns:cdv="http://cordova.apache.org/ns/1.0">
    <name>мојЧоек</name>
    <description>Get things done</description>
    <author email="email@gmail.com" href="https://mojcoek.mk">The мојЧоек Team</author>
    <content src="index.html" />
    <allow-intent href="https://*/*" />
    <allow-intent href="mailto:*" />
</widget>

package.json:

{
  "name": "com.gotaguyapp",
  "version": "0",
  "displayName": "мојЧоек",
  "cordova": {
    "platforms": [
      "ios"
    ],
    "plugins": {
      "cordova-plugin-whitelist": {},
      "cordova-plugin-firebase-lib": {}
    }
  },
  "dependencies": {
    "cordova-ios": "^5.0.1",
    "cordova-plugin-androidx-adapter": "^1.1.0",
    "cordova-plugin-firebase-lib": "^5.1.1"
  },
  "devDependencies": {
    "cordova-plugin-whitelist": "^1.3.3"
  }
}
sagrawal31 commented 5 years ago

What's your pod version?

Birowsky commented 5 years ago

@sagrawal31 pod --version: 1.7.3

sagrawal31 commented 5 years ago

Can you try changing the name with English like <name>Onions</name> and re-install platforms:

rm -rf platforms/ios
cr platform add ios@5.0.1
cr build ios
Birowsky commented 5 years ago

Oh yeah, that works perfectly. I thought it was implied, sorry. Only if I add at least a single cyrillic character, it fails.

In example, if I set the name to "sssЏsss", it's gonna fail with:

ld: framework not found Pods_sss_sss
clang: error: linker command failed with exit code 1 (use -v to see invocation)
sagrawal31 commented 5 years ago

So basically, Cordova (or probably iOS) doesn't support Cyrillic character in its name.

Birowsky commented 5 years ago

Without this plugin, it compiles successfully.

sagrawal31 commented 5 years ago

Hmmmm....Then probably Firebase SDK is not able to handle Cyrillic alphabets as it uses Cocoapods to install dependencies.