search

wiztrust / php-reader

Automatically exported from code.google.com/p/php-reader
0 stars 0 forks source link

possible typo #9

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I was poking around in the code and I saw this function in Transform.php:

  public static function fromString16($value)
  {
      if ($value[0] == 0xfe && $value[1] = 0xff)
        return self::fromString16BE(substr($value, 2));
      else
        return self::fromString16LE(substr($value, 2));
  }

I hate to comment about code I know little of but it looks like there is a typo 
here.  Is the second 
line below correct?
if ($value[0] == 0xfe && $value[1] = 0xff)
if ($value[0] == 0xfe && $value[1] == 0xff)

(also I don't know if you want ordinary users posting stuff here, please let me 
know if this is not 
the case)

Original issue reported on code.google.com by rgig...@gmail.com on 17 Jul 2008 at 6:03

GoogleCodeExporter commented 9 years ago 
This is fixed in my ID3v2 improvements which can be found here: 
http://code.google.com/p/php-
reader/issues/detail?id=11

Original comment by but...@gmail.com on 29 Jul 2008 at 12:48

GoogleCodeExporter commented 9 years ago

Original comment by svollbehr on 29 Jul 2008 at 7:03

GoogleCodeExporter commented 9 years ago 
Issue solved, thanks for reporting

Original comment by svollbehr on 30 Jul 2008 at 2:58

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago

Original comment by svollbehr on 20 Feb 2009 at 9:21