wizzomafizzo / MiSTer_Favorites

Add and manage favorites in your MiSTer menu.
MIT License
68 stars 3 forks source link

How is the inner `cores` folder kept up to date? #12

Open felleg opened 2 years ago

felleg commented 2 years ago

Context: I have recently made an update_all.sh run that added R-Type II to my .mras files. I proceeded to add R-Type II as a favorite, however it wouldn't let me run the game. I realized this is because my /media/fat/_@Favorites/cores folder didn't yet contain the new R-Type II core.

Can someone replicate this issue? If so, I think it would be convenient to add a command to the favorites script that updates the cores/ folder automatically. :)

wizzomafizzo commented 2 years ago

I never thought about this before but yeah this is definitely going to be an issue. When you symlink an mra file you also need to symlink the cores folder. I hardcore the one in _Arcade which works for the most part. But there's actually nothing stopping you from having an mra that uses its own cores folder (I think llapi and yc cores do this)

It won't be as simple as linking the respective cores folder either. What if you have 2 arcade symlinks in the same folder that use a different cores folder? Tricky

So yeah it needs some thought but I think your idea of having the script manage the central arcade cores folder somehow is the only way it can work properly