wizzomafizzo / mrext

Collection of extensions and utilities for the MiSTer system.
GNU General Public License v3.0
179 stars 11 forks source link

Bug with the SMS/GG core? #72

Open Waifu4Life opened 1 year ago

Waifu4Life commented 1 year ago

I think I found out some sort of bug or whatever. Normally, if I run the SMS core, if I choose to load a Master System or GameGear game, the core will expect an SMS folder in the Games folder and the options of the core for button mapping will say "Define SMS buttons". That being said, if I try to load a GameGear game using NFC, the core then expects the games to be in a "GameGear" folder and the options of the core for button mapping will say "Define GameGear buttons". How can your script change the core like this?

Off-topic, I can't figure out how to tag NEOGEO games and Arcade games.

Cheers

sigboe commented 1 year ago

This is done using an .mgl "shortcut". You should have a Game Gear.mgl file in the _Console folder on your SD Card. And it's contents should be something like

<mistergamedescription>
    <rbf>_Console/SMS</rbf>
    <setname>GameGear</setname>
</mistergamedescription>

Where the setname overrides the core name

sigboe commented 1 year ago

Off-topic, I can't figure out how to tag NEOGEO games and Arcade games.

How are you making a tag? Are you using the nfcui? If you are using the user interface, what does your tag that isn't working look like? If you are using the NFCUI to make a neogeo game tag, and it is not working, I would love to figure out why, and try to handle situations where tags are not made correctly!

Waifu4Life commented 1 year ago

@sigboe I don't use .mgl shortcuts, all of my tags are programmed to give the full path on my MiSTer's MicroSD card. Only sort of file I use is the name.txt in my main MiSTer folder so that te consoles are renamed to their proper Japanese names.

I'm using this to make tags: https://www.wakdev.com/en/apps/nfc-tools-pc-mac.html I just want to know how to point these types of games (NEOGEO and other arcade games). For example: /media/fat/games/MegaDrive/Castlevania - Bloodlines.md /media/fat/games/Saturn/Daytona USA Circuit Edition/Daytona USA Circuit Edition.cue /media/fat/games/NEOGEO/kof2000??????? /media/fat/games/mame/punisherj.zip??????

sigboe commented 1 year ago

I don't use .mgl shortcuts, all of my tags are programmed to give the full path on my MiSTer's MicroSD card. Only sort of file I use is the name.txt in my main MiSTer folder so that te consoles are renamed to their proper Japanese names.

The NFC service does it this way, does this give you any adverse effects?

I'm using this to make tags: https://www.wakdev.com/en/apps/nfc-tools-pc-mac.html

You should not use the full path, you may remove /media/fat/games. When I became aware of this issue I started to review the code for the NFC UI, and I actually found the same bug, when searching for a game instead of picking a file, I did not clean up the path. Which is the same issue as this! I've pushed the fix, I assume wizzo will want to push that fix to a release sooner rather than later. (which adds this fix to update_all.sh if you enabled mrext)

Your KOF2000 and Punisher should point to mra or neo file

Example like this (if you are using the NFC UI) image

or this (if you are using neo files) image

sigboe commented 1 year ago

After talking to wizzo, full path should work (My nfc reader hasn't arrived yet, so I have not been able to test it) Anyway, the screenshots of the NFCUI above should show examples of working punisher and KOF