search

wizzomafizzo / tapto

Launch games using physical objects
GNU General Public License v3.0
64 stars 9 forks source link

Just log socket creation error #58

Closed wizzomafizzo closed 1 month ago

wizzomafizzo commented 1 month ago

Since the socket is now only used by external apps, just log and ignore if its creation fails as it's no longer critical to the service running. Issues can still be resolved for external apps by rebooting.

I was going to pull it out into the mister platform module but it also requires implementing the platform-generic config module to resolve a cyclic dependency sooo I didn't do that yet

asturur commented 1 month ago

i had an issue with the tapto.sock file and i couldn't use tapto at all. Is that because of us returning error or becuase tapto.sock is really necessary?

wizzomafizzo commented 1 month ago

i had an issue with the tapto.sock file and i couldn't use tapto at all. Is that because of us returning error or becuase tapto.sock is really necessary?

Back when both the main tapto.sh status screen and taptui.sh script required the socket to function yes it was a critical error and the service could not effectively function without it. But now it's not such a big deal. It's happening because it couldn't clean up the previous connection and the tapto.sock file still existed from the last run. There is no attempt to delete and recreate the file on launch

I want to keep the socket around for backwards compatibility for the forseeable future on mister. But it should be disabled on all other platforms even if they support a unix socket

There is a question in my mind though. I also got this error a lot. Why are all 3 of us getting this error now and it wasn't really an issue before? Is something changed or is it a coincidence?