wizzomafizzo / tapto

Launch games using physical objects
GNU General Public License v3.0
64 stars 9 forks source link

WIP Create new Reader interface #67

Closed wizzomafizzo closed 3 days ago

wizzomafizzo commented 6 days ago

This PR separates the existing libnfc code into a separate module and exposes it as a new Reader interface. This will have some really nice benefits:

I think it just generally makes the daemon process much easier to read and deal with as well.

The PR is still incomplete. Before it's merged I still need to:

wizzomafizzo commented 4 days ago

all tests passing finally! this code now works exactly how it did before 🥳

@asturur sorry for rewriting so much of the code. i tried for a couple of days to edit the existing way and make it work but it was so complex to do it with the way i am using channels now. at least i have no lost any functionality in the rewrite

next i will add some basic support for multiple readers at once, and then i'll stick a fork in this

wizzomafizzo commented 3 days ago

ok, all good. no regressions as far as i can tell

scanning behaviour should be exactly the same as previously, following the test results in the docs