search

wj331 / pe

0 stars 0 forks source link

Bug for adding a booking when there is an invalid date #2

Open wj331 opened 1 year ago

wj331 commented 1 year ago

image.png

image.png

As seen, tried to add a booking with date 02-30 and 31st april which is an invalid date but it is not giving me the correct error.

This could cause some occasional inconvenience to users if they accidentally enter wrong dates

nus-se-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unclear error message when wrong date is entered

image.png

As error message is so long Booking periods must be in the format 'YYYY-MM-DD HH:MM to YYYY-MM-DD HH:MM', and the end datetime must come after the start datetime.

It is unclear whether my input is wrong with my format or whether it is because of the start and end time. This results in lower testability which is a feature flaw.

[original: nus-cs2103-AY2324S1/pe-interim#538] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Tester inputs the year as "0001" which is extreme user behaviour, then claims "It is unclear whether my input is wrong with my format or whether it is because of the start and end time."

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The 'Original' Bug is about entering year 0001 but my bug report is about entering invalid dates that does not exist in the calendar so they are obviously 2 different bugs

image.png

This is my bug report which says I am trying to make a booking on 30th February or 31st April.

image.png

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** As a hotel employee managing bookings, I might not know what are valid dates and what are invalid dates. Eg How would I know April has no 31st (I personally did not know until I searched it up). So if a user is using this and enters "31st April" into the date parameter, the app will return error **NOT IN CORRECT FORMAT** As a user, my next reaction would be to check whether it is in the correct format, and clearly it is. So how is the user going to find the issue with the invalid date? There must be different ways of handling invalid date inputs instead of just `Booking periods must be in the format 'YYYY-MM-DD HH:MM to YYYY-MM-DD HH:MM', and the end datetime must come after the start datetime.` This is yet another feature flaw that makes the feature of adding an appointment "less useful" since it does not help employees correct the error. As seen in the following screenshot, wrong error message despite how the date format is already **correct**: ![image.png](https://raw.githubusercontent.com/wj331/pe/main/files/de9bccfe-188c-40ad-bfbb-c70910545b18.png)
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Severity should be Medium. It causes `occasional inconvenience to some users` since they might sometimes enter invalid dates such as 30th February and the program **WILL NOT** help the user identify that the date is invalid but instead **TELLS** the user that the format is wrong **INCORRECTLY**