Bug in FIND when the INDEX is negative

[wj331]

Enter find -3 and this is what the UI returns me with no error messages

Same issue for find 0

This is could make the product almost unusable especially when room numbers are between 1 and 500

[nus-pe-script]

Team's Response

This issue is denied as both the User and Developer guides clearly outline the valid range for the Room Numbers (1 to 500 inclusive):

As such, not only is the user unlikely to ever search for a zero or negative room number (as it is out of the accepted range), the existing message as shown in the screenshot provided:

clearly indicates that no such bookings can be found.

Additionally, as the find command is used to search by name:

and several names involve the '-' symbol, the find command cannot be modified to strictly reject the '-' symbol.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement: Agree with the developers that the room numbers should be ofcourse positive. BUT there should have been an error message returned to me otherwise what is the program actually finding? This is a bug that should have been caught and reflected to the user that the input INDEX is incorrect!

Furthermore, the success message tells me that finding -3 was successful but since there is no room -3, how can it be successful?

Imagine if a user wants to find room 3 but accidentally typos and inserts -3, this could cause confusion and inconvenience to the user since an error is not raised and it just returns 0 bookings found which the user might be wondering why is find 3 returning me 0 bookings found when there is in fact some bookings for room 3?

---

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [x] I disagree **Reason for disagreement:** Decided to change to severity.Medium This flaw that does not throw any errors for negative room will cause occasional inconvenience and confusion to some users, especially when they accidentally typo a `-` infront of the number. IF `several names involve the '-' symbol, the find command cannot be modified to strictly reject the '-' symbol.` as mentioned by the developers, THIS should have been separated into **2 DIFFERENT FIND** functions that do not overlap with each other. Combining them only results in confusion and restrictiveness on the feature itself.

---