Fix visibility for GCC on Windows (mingw64)

wjakob / nanobind

nanobind: tiny and efficient C++/Python bindings

BSD 3-Clause "New" or "Revised" License

2.29k stars 191 forks source link

Closed lkeegan closed 5 months ago

lkeegan commented 5 months ago

revert change from https://github.com/wjakob/nanobind/pull/440
- dllexport was/is correct on Windows, including with mingw64 gcc compiler
don't set visibility("hidden") attribute for namespaces on windows
- this resolves the original mingw64 compilation error seen in #440

wjakob commented 5 months ago

cc @laggykiller -- do you have any feedback on this change?

laggykiller commented 5 months ago

@wjakob Not expert, but looks good to me

wjakob commented 5 months ago

Ok, thanks! -- merged.