Widget scissoring cutting elements

[fairlight1337]

After staring at example1 a bit more, I realized that the widget scissoring introduced earlier is making more trouble that initially thought:

The image view and the popup widget both are cut off (and there might be more), because they draw outside of their designated areas. Both could be resolved by appropriately drawing inside the bounds, and in case of the popup, moving it and drawing the background and contents with an offset to the right (or left, wherever the popup arrow is).

Right now I'm just raising attention about this, as I'm on a pretty tight schedule; I'll see after wringing out some time to fix those.

[wjakob]

I noticed this as well. I pushed out a bunch of changes that should hopefully fix everything.

Best, Wenzel

On 7 Nov 2016, at 11:26, Jan Winkler notifications@github.com wrote:

After staring at example1 a bit more, I realized that the widget scissoring introduced earlier is making more trouble that initially thought:

https://cloud.githubusercontent.com/assets/1122132/20054330/c102f64a-a4dc-11e6-9c0c-673f9dd30ce0.png https://cloud.githubusercontent.com/assets/1122132/20054331/c1032de0-a4dc-11e6-8c31-47809b57c350.png https://cloud.githubusercontent.com/assets/1122132/20054329/c103018a-a4dc-11e6-87a5-3f184a96810f.png The image view and the popup widget both are cut off (and there might be more), because they draw outside of their designated areas. Both could be resolved by appropriately drawing inside the bounds, and in case of the popup, moving it and drawing the background and contents with an offset to the right (or left, wherever the popup arrow is).

Right now I'm just raising attention about this, as I'm on a pretty tight schedule; I'll see after wringing out some time to fix those.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wjakob/nanogui/issues/168, or mute the thread https://github.com/notifications/unsubscribe-auth/ABJdrXlIKE_C_1xL7shu9vkzasXUubCVks5q7vzEgaJpZM4KrDPo.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/wjakob/nanogui","title":"wjakob/nanogui","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/wjakob/nanogui"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Widget scissoring cutting elements (#168)"}],"action":{"name":"View Issue","url":"https://github.com/wjakob/nanogui/issues/168"}}}

[fairlight1337]

Oh, I see - haven't seen those yet. Thanks.

Jan