search

wjakob / nanogui

Minimalistic GUI library for OpenGL
Other
4.66k stars 608 forks source link

possible correction to the documents' Compile instructions #336

Open xkunglu opened 6 years ago

xkunglu commented 6 years ago

hi guys, this is minor and I only tried in Ubuntu and MacOS (with and without conda which is what i use ) i wont fork and pull request. Compile instructions should read

git clone --recursive https://github.com/wjakob/nanogui cd nanogui mkdir build cd build cmake .. sudo make install -j4 cp python/*.so python -c 'import site;print(site.getsitepackages()[0])'

note. the line python -c 'import site;print(site.getsitepackages()[0])' needs to be surrounded by ` , the github form interprets is as formating

or maybe instructions for a pip package. Or maybe this change could be reflected in the cmake instructions. This works for me not adding the last line prevents nanogui to work simply in python, which may stumble some users

svenevs commented 6 years ago

If you just want to be able to import nanogui from python on your system, use the future version of NanoGUI -- it has a setup.py making python installation seamless :)

In the not too distant future this repo will become legacy / only receive bugfixes, and most of the cool new features (such as the WebAssembly stuff) will never be backported to this repo.

As is those instructions are not quite correct / not platform independent -- you should simply add CMAKE_INSTALL_PREFIX/lib (wherever you installed to) to your $PYTHONPATH, and need to add the same directory to either your LD_LIBRARY_PATH or possibly DYLD_LIBRARY_PATH on osx.

xkunglu commented 6 years ago

thank you for both pieced of information!

xkunglu commented 6 years ago

Hey Jakob, Stephen, i just checked, fyi, the enoki depo which is pulled by mitsuba-renderer/nanogui is not public, neither site linked in docs, nor the git clone --recursive allows me in. thanks

wjakob commented 6 years ago

Hi @xkunglu, that's right. This is a future version of NanoGUI that builds on some software which hasn't been released yet.

xkunglu commented 6 years ago

thanks, ill build my apps over the old version then. cheers

svenevs commented 6 years ago

Hi @xkunglu sorry for pointing you to the future version prematurely!

Is everything working out for you now / can we close this issue?