search

wjakob / nanogui

Minimalistic GUI library for OpenGL
Other
4.66k stars 608 forks source link

reserved identifier violation #7

Closed elfring closed 9 years ago

elfring commented 9 years ago

I would like to point out that identifiers like "__NANOGUI_CHECKBOX_H" and "__NANOGUI_GRAPH_H" do not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

wjakob commented 9 years ago

Hi elfring,

what's an officially approved workaround? I'd be tempted to just get rid of the #ifdefs and switch to #pragma once, but that is not an official extension either, right?

Thanks, Wenzel

elfring commented 9 years ago

How do you think about to delete the leading underscores from the affected include guards?

wjakob commented 9 years ago

fixed.

elfring commented 9 years ago

Would you like to reconsider the reuse of the construct "#pragma once"?

elfring commented 9 years ago

Are there a few update candidates left over?