wjakob / tbb

Intel TBB with CMake build system
Apache License 2.0
369 stars 161 forks source link

Update to 2020.2 #65

Closed jschueller closed 4 years ago

wjakob commented 4 years ago

These looks like fantastic improvements, please let me know once this is ready to merge. One request: can you set the Swig Python extension feature to default-off? Most projects using this repository are C++-based and compile TBB recursively as static or shared library to keep the user from having to deal with the dependency. Including Python here will make the build slower, and potentially more fragile.

wjakob commented 4 years ago

I also think that you overwrote some project-specific files when untarring TBB, like our readme.

jschueller commented 4 years ago

I also think that you overwrote some project-specific files when untarring TBB, like our readme.

yes, it's difficult to update version because of that, but it's fixed

wjakob commented 4 years ago

If I understood your changes correctly, we are no longer testing 32 vs 64 bit on windows. That would be problematic, we should at least have both for one of the MSVC versions.

jschueller commented 4 years ago

If I understood your changes correctly, we are no longer testing 32 vs 64 bit on windows. That would be problematic, we should at least have both for one of the MSVC versions.

ok, lets build for 64 for vs2017 and vs2019, and 32 for vs2015, its not necessary to have all combinations, appveyor builds are slow enough

jschueller commented 4 years ago

These looks like fantastic improvements, please let me know once this is ready to merge. One request: can you set the Swig Python extension feature to default-off? Most projects using this repository are C++-based and compile TBB recursively as static or shared library to keep the user from having to deal with the dependency. Including Python here will make the build slower, and potentially more fragile.

ok

jschueller commented 4 years ago

@wjakob I think its ready

wjakob commented 4 years ago

Merged, thank you!