search

wjaspers / phabricateme

A chrome extension for keeping you connected with your Phabricator instance.
http://phabricator.org/
Other
5 stars 1 forks source link

OAuth2 Phabricator Adapter Lookup Failing #5

Open wjaspers opened 10 years ago

wjaspers commented 10 years ago

The redirectURL() is used to find the adapter when the OAuth2 library is injected. A side-effect of not having any unit tests or solid footing as to how our extension will consume OAuth, the redirectURL onLoad is using properties that are inaccessible on boot.

wjaspers commented 10 years ago

After much thought, I've come to the conclusion that using the OAuth adapter library isn't effective in this particular extension. The future direction will be to remove the OAuth adapter library and handle the flow internally