search

wjchoi0712 / pe

0 stars 0 forks source link

Feature does not account for empty parameter #7

Open wjchoi0712 opened 3 years ago

wjchoi0712 commented 3 years ago

The delete cs command takes in empty parameter which makes the error message look weird

image.png

nus-pe-bot commented 3 years ago

Team's Response

We believe that this is purely aesthetics and up to personal preference. Some users may feel that it is a valid input, with blank being the name of their cheat-sheet. (Even though it is not allowed)

At the end of the day, both messages would provide the users receives the same information: There is no file called ".txt" and thus they cannot open it.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Provided that blank names are not allowed for cheat-sheet, I feel that the error message must be explicit in explaining to user that parameter of cheatsheet name cannot be empty when deleting cheet sheets.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]