search

wjdp / htmltest

:white_check_mark: Test generated HTML for problems
MIT License
325 stars 54 forks source link

GO net/url doesn't allow ctrl chars in url #117

Closed jgielstra closed 5 years ago

jgielstra commented 5 years ago

Go's net/url parser doesn't like \n inside the url. See: https://github.com/golang/go/blob/7b62e984d941c753e7fb20f8b59a49acf62c88a7/src/net/url/url.go#L516

FYI src+data with newlines is valid in chrome/firefox/..

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@03401a7). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #117   +/-   ##
=========================================
  Coverage          ?   86.53%           
=========================================
  Files             ?       20           
  Lines             ?     1062           
  Branches          ?        0           
=========================================
  Hits              ?      919           
  Misses            ?      136           
  Partials          ?        7

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 03401a7...f4e6d05. Read the comment docs.

wjdp commented 5 years ago

Interesting, thanks very much for the fix. Will have to look into this.