search

wjdp / htmltest

:white_check_mark: Test generated HTML for problems
MIT License
323 stars 54 forks source link

Fix failing test with invalid port by adding popper handling of the error #132

Closed tomtom5152 closed 4 years ago

tomtom5152 commented 4 years ago

Will also handle other reference errors more gracefully.

Closes #127.

codecov[bot] commented 4 years ago

Codecov Report

Merging #132 into master will decrease coverage by 2.62%. The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   86.58%   83.96%   -2.63%     
==========================================
  Files          20       20              
  Lines        1066     1110      +44     
==========================================
+ Hits          923      932       +9     
- Misses        136      166      +30     
- Partials        7       12       +5
Impacted Files Coverage Δ
htmltest/check-link.go 97.64% <100%> (+0.06%) :arrow_up:
htmldoc/reference.go 100% <100%> (ø) :arrow_up:
htmltest/check-script.go 78.78% <12.5%> (-21.22%) :arrow_down:
htmltest/check-generic.go 81.08% <12.5%> (-18.92%) :arrow_down:
htmltest/check-img.go 84.09% <12.5%> (-15.91%) :arrow_down:
htmltest/check-meta.go 86% <36.36%> (-14%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d9b1c7e...6d236af. Read the comment docs.