wjdp / htmltest

:white_check_mark: Test generated HTML for problems
MIT License
323 stars 54 forks source link

Support installation on OpenBSD/amd64 #141

Closed leonstafford closed 4 years ago

leonstafford commented 4 years ago

Unable to install on OpenBSD

Add support for installation on OpenBSD, doas v sudo, ksh over bash

Haven't looked into what is required for PR yet

wjdp commented 4 years ago

I have zero experience with BSD, would appreciate some help here.

leonstafford commented 4 years ago

@wjdp happy to help! Wanted to get the feature request in at least. I have zero experience with Go, but should be able to do some prep/maybe a PR.

Thinking out loud:

leonstafford commented 4 years ago

Checking out source allows it to build and execute fine for me on -current version of OpenBSD.

So, will check what can be done to the docs / public install script currently failing

leonstafford commented 4 years ago

public install script generated by https://github.com/goreleaser/godownloader, no longer actively maintained, but has some activity in repo.

If contributing upstream to godownloader doesn't make sense, can look to patch current generated installer script to support OpenBSD

Caddy installer script for reference supporting OpenBSD

leonstafford commented 4 years ago

alternatively, add notes in docs for installation on OpenBSD:

leonstafford commented 4 years ago

may also be able to adjust goreleaser usage to build release for OpenBSD, similar to recommended install steps for Windows

wjdp commented 4 years ago

Have merged the MR but not on a machine where I can tag a new release today. Should be able to soon.

wjdp commented 4 years ago

Hi @leonstafford. Release is done, can you pull one of the binaries and check it works on your machine?

https://github.com/wjdp/htmltest/releases/tag/v0.12.1

leonstafford commented 4 years ago

@wjdp many thanks! Working well here (amd64) 😸