search

wjdp / htmltest

:white_check_mark: Test generated HTML for problems
MIT License
323 stars 54 forks source link

Using ENTRYPOINT to simplify docker run semantics #144

Closed mtlynch closed 4 years ago

mtlynch commented 4 years ago

This change specifies htmltest as the ENTRYPOINT command in the Dockerfile. This change makes it so that Docker concatenates the ENTRYPOINT and the CMD. The big benefit is that clients don't have to redundantly type the binary name when they run the Docker image.

Instead of this:

docker run -v /home/mike/htmltest:/test --rm wjdp/htmltest htmltest -l 3 -s

they can leave out the second 'htmltest' like this:

docker run -v /home/mike/htmltest:/test --rm wjdp/htmltest -l 3 -s

codecov[bot] commented 4 years ago

Codecov Report

Merging #144 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   83.27%   83.27%           
=======================================
  Files          20       20           
  Lines        1160     1160           
=======================================
  Hits          966      966           
  Misses        174      174           
  Partials       20       20

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e3e969...c119663. Read the comment docs.