wjdp / htmltest

:white_check_mark: Test generated HTML for problems
MIT License
323 stars 54 forks source link

Crash when installing on zsh/macos #146

Open damien1 opened 4 years ago

damien1 commented 4 years ago

Hi

as zsh is the default in new macs - please can you provide instructions for install htmltest in zsh

thanks

wjdp commented 4 years ago

I don't have access to a Mac so am dependant on others for help here.

Saying that the shell shouldn't make any difference to the install process. I use zsh on Linux and there's no difference to the install process there.

What happens when you try the install process on osx?

jonasrosland commented 4 years ago

Here's my result running the install on a Mac with zsh, it ends up not being installed:

curl https://htmltest.wjdp.uk | sudo bash -s -- -b /usr/local/bin

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  9932  100  9932    0     0  24283      0 --:--:-- --:--:-- --:--:-- 24224Password:

[1]  + 70878 done                   curl https://htmltest.wjdp.uk |
       70879 suspended (tty input)  sudo bash -s -- -b /usr/local/bin

Running it in bash works and installs it correctly.

wjdp commented 3 years ago

Likely the godownloader script. Will upgrade it and see if that helps.

wjdp commented 3 years ago

@jonasrosland @damien1 I have updated the script. Could you try again and let me know if it works now?

shelbyspees commented 3 years ago

I think I'm running into this same issue. MacOS Big Sur 11.2.3 (20D91). Downloading via cURL (per my project's makefile):

$ curl https://raw.githubusercontent.com/wjdp/htmltest/master/godownloader.sh | bash

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  9932  100  9932    0     0  37764      0 --:--:-- --:--:-- --:--:-- 37764
wjdp/htmltest info checking GitHub for latest tag
wjdp/htmltest info found version: 0.14.0 for v0.14.0/osx/amd64
$ echo $?                                                                           
1

I tried piping into zsh instead of bash and it failed the same way. Here's the version info if that helps:

$ zsh --version
zsh 5.8 (x86_64-apple-darwin20.0)
$ bash --version
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin20)
Copyright (C) 2007 Free Software Foundation, Inc.
$ curl --version
curl 7.64.1 (x86_64-apple-darwin20.0) libcurl/7.64.1 (SecureTransport) LibreSSL/2.8.3 zlib/1.2.11 nghttp2/1.41.0
Release-Date: 2019-03-27
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: AsynchDNS GSS-API HTTP2 HTTPS-proxy IPv6 Kerberos Largefile libz MultiSSL NTLM NTLM_WB SPNEGO SSL UnixSockets

When I downloaded htmltest_0.14.0_macos_amd64.tar.gz directly from the releases page it ran fine in my project:

$ bin/htmltest                                                                      
htmltest started at 09:22:52 on public
========================================================================
✔✔✔ passed in 274.30098ms
tested 368 documents

It doesn't break our CI. I'm letting the project maintainers know about the snag for local development on MacOS.

chalin commented 3 years ago

@jonasrosland @damien1 I have updated the script. Could you try again and let me know if it works now?

It works for me under zsh & macOS 11.4.

It's also nice that we can brew install htmltest now.

Thanks!

wjdp commented 3 years ago

@shelbyspees I very much missed you were running the script from raw.githubusercontent.com rather than htmltest.wjdp.uk. Both should work however I failed to update the repo copy when regenning the script. #171 will fix this.

Sorry for not spotting this sooner.