Apply IgnoreURLs regexs to internal and file URLs too

wjdp / htmltest

:white_check_mark: Test generated HTML for problems

MIT License

323 stars 54 forks source link

Apply IgnoreURLs regexs to internal and file URLs too #175

Closed chalin closed 2 years ago

chalin commented 2 years ago

Closes #109
Solves the original request of #168

chalin commented 2 years ago

Friendly ping @wjdp

chalin commented 2 years ago

Friendly ping @wjdp - it has been two months now. Thanks.

chalin commented 2 years ago

4 month ping @wjdp - do you have an ETA for when this PR is likely to be reviewed? Thanks.

felixminom commented 2 years ago

@wjdp will be good to have this reviewed and merged. Facing the same issue :/

wjdp commented 2 years ago

Hi @chalin, very sorry for delay on this. Reading through the issues and MRs around this it would seem to make more sense to combine all ignoring into the IgnoreURLs option and deprecate the IgnoreInternalURLs option as it's very specific and can be handled just with IgnoreURLs, will do some testing and look to get this merged.

chalin commented 2 years ago

Great! Thanks for the heads up. Looking forward to this new capability.