wjdp / htmltest

:white_check_mark: Test generated HTML for problems
MIT License
323 stars 54 forks source link

Default Docker usage ignores config #178

Open tillepille opened 2 years ago

tillepille commented 2 years ago

Describe the bug

When running the default command from the readme, the configfile is ignored

To Reproduce

Example layout

.
├── .htmltest.yml
├── README.md
├── node_modules
│   ├── .bin
│   ├── .yarn-integrity
│   ├── @babel
│   ├── accepts
├── public
│   ├── index.html
│   └── style.css
  1. start test with docker run -v $(pwd):/test --rm wjdp/htmltest

Then the config is ignored and all folders e.g node_modules is scanned.

.htmltest.yml

DirectoryPath: public

Source files

Please include any relevant lines from the directory you were using htmltest on. Ideally you would be able to find a single line that if included causes this bug.

Expected behaviour

I expect the config is read, even when a path is specified via argument

Actual behaviour

config is ignored, caused by the path specification in the Dockerfile

Versions

Additional context

One mitigation would be to remove that mentioned line from the dockerfile, but maybe this would also help for "normal" usage, that the app looks for a configfile in the current working directory.