search

wjdp / htmltest

:white_check_mark: Test generated HTML for problems
MIT License
325 stars 54 forks source link

Fix panic when referencing ignored directories #181

Closed markmandel closed 2 years ago

markmandel commented 2 years ago

This fix includes two things:

  1. Check for ok value from ResolveRef in checkInternalHash. If a value was ignored but was a valid link, it would panic as it was not found.
  2. Change the behaviour of discoverRecurse such that it keeps all found Documents, but adds a new IgnoreTest attribute such that we can track if it should be skipped on test, but still referenced in a test.

Closes #126

markmandel commented 2 years ago

Looks like my go fmt picked up a few formatting changes across the codebase. Please let me know if you would like me to revert them.

wjdp commented 2 years ago

@markmandel Thank you for this, sorry for the late action