search

wjdp / htmltest

:white_check_mark: Test generated HTML for problems
MIT License
323 stars 54 forks source link

Add possibility to ignore based on existing class #213

Closed aepfli closed 1 year ago

aepfli commented 1 year ago

Ingoring by tag attribute is helpful, but eg. docusaurus does not offer a good way to manipulate its theme. But it offers a way to always attach a custom class.

With this approach, we will reuse the IgnoreTagAttribute as a class name detection.

It isn't worth specifying an additional attribute for this use case, although the naming might be off now.

Disclaimer I did not find a contributing guide, so I went ahead and created this pr. If you prefer to discuss this first in an issue, I will also gladly create one.

aepfli commented 1 year ago

thank you! - if there should be any regression or follow-up just let me know, i am always glad to help

wjdp commented 1 year ago

Will do!

aepfli commented 1 year ago

Disclaimer: I am not in a hurry :) I am just curious :)

Do you know when this might be released?

wjdp commented 1 year ago

Soon but uncertain, when I get around to sitting down and doing it. I tend to check on issues/PRs here when I'm not in a position to actually do it so it tends to get forgotten :disappointed: Will try and do within week or so.

In the meantime if you can use the linux or mac versions CI builds you can grab from https://github.com/wjdp/htmltest/actions/runs/4448775063