search

wjdp / htmltest

:white_check_mark: Test generated HTML for problems
MIT License
323 stars 54 forks source link

fix: ignore generic if data-proofer-ignore is iset #79

Closed caarlos0 closed 6 years ago

caarlos0 commented 6 years ago

data-proofer-ignore was not being respected on iframes

codecov-io commented 6 years ago

Codecov Report

Merging #79 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #79      +/-   ##
=========================================
+ Coverage   85.87%   85.9%   +0.02%     
=========================================
  Files          20      20              
  Lines        1055    1057       +2     
=========================================
+ Hits          906     908       +2     
  Misses        142     142              
  Partials        7       7
Impacted Files Coverage Δ
htmltest/check-generic.go 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e8d4958...1b17d9d. Read the comment docs.

caarlos0 commented 6 years ago

ping @wjdp

wjdp commented 6 years ago

Hey @caarlos0, sorry for not looking at this yet. I'm busy this weekend but will endeavour to do next week.

caarlos0 commented 6 years ago

Thanks! =D

wjdp commented 6 years ago

No worries, thanks for the contributions!