search

wjunkin / moodle-quiz_liveviewgrid

Dynamic quiz spreadsheet
2 stars 2 forks source link

Here i go again #18

Closed dinism closed 5 years ago

dinism commented 5 years ago

The text of the buton is hardcoded. Sorry about this. imagem

And what about this phenomenon? imagem

Take a look here! imagem

wjunkin commented 5 years ago

Thanks for catching this. I have corrected the code (added in the needed language string). You will need to clear cache. I don't know how to align the text in a button with other text but I will work on this. You noted that the time in the program and the time in the computer were different. This may be caused by the time on the server being slightly different from the clock in the computer.

dinism commented 5 years ago

In your recent added code (commit 315163d): $string['newpage'] = "New page, static & printable"; Should be(?) $string['newpage'] = 'New page, static & printable';

dinism commented 5 years ago

When you are in a STATIC page and if you select other group you GO BACK. It opens the principal page in static page tab of the browser with goup you selected. The same happens when you viewing a single question on a static page and you select other question. If it's not possible change group or question i think it's better not show the option to change group or question. It's only my opinion.

dinism commented 5 years ago

Take a look to messages in the images: imagem imagem Take a look to number 1,2 and 3. Why this happens? User1 name = "João" + surname = "Cabeça Branca" ► João Cabeça Branca. It adjust to column width. User2 name = "Ruben" + surname = "Cerqueira" ► Ruben Cerqueira. It DON'T adjust to column width User3 name = "Rodrigo" + surname = "Morganheira" ► Rodrigo Morganheira. It DON'T adjust to column width

wjunkin commented 5 years ago

Thanks for your comments and suggestions. I am on vacation for a week and will see what I can do when I'm back home.

wjunkin commented 5 years ago

Hi, I like your suggestion that I remove all links and options that allow teachers to go from a static page to any other page. I think navigation will be much cleaner and easier for teachers to understand if all navigation to a static page goes from the dynamic page. I am on vacation but will make this change in a week.

wjunkin commented 5 years ago

Hi, Dinis, I think that the new version has taken care of two of the issues that you mentioned. I think that the timing issue (if I understand your comment correctly) is just caused by a difference in the time on the server vs the time on your computer. Also, I think the current version has used your suggestion about making the navigation much clearer and cleaner (thank you very much). Based on this I am closing this issue but please feel free to let me know if this or anything else should be changed and thanks for your help.

dinism commented 5 years ago

Hi But where is the new version? Last commit 7 days ago. image

wjunkin commented 5 years ago

My fault, Dinis, I wrote my email to you before I finished the commit to this site and then I stopped to watch the Women's World Cup Soccer. The new version has been posted here now.