search

wjwwood / serial

Cross-platform, Serial Port library written in C++
http://wjwwood.github.com/serial/
MIT License
2.11k stars 1.03k forks source link

Noetic Release #222

Closed tonybaltovski closed 2 years ago

tonybaltovski commented 4 years ago

Could you please do a release for Noetic?

doisyg commented 4 years ago

Yes, that would be nice as many drivers rely on this

gmsanchez commented 4 years ago

Yes, please

Juba19 commented 4 years ago

Agree, I hope soon ! It will be a helpful tool for NOETIC. Thank you

droemer7 commented 4 years ago

Seconding this as well, but I suppose it can be built from source and should work?

doisyg commented 4 years ago

Seconding this as well, but I suppose it can be built from source and should work?

Yes, working for me from src

Tobias-Fischer commented 3 years ago

Ping @wjwwood Working for me fine from src, too.

joshnewans commented 3 years ago

It would be great to have this available as a noetic release. It is working fine from source for me, but it is a dependency for my package which I would like to be able to distribute for noetic.

stwirth commented 3 years ago

@wjwwood ping

julianraheema commented 3 years ago

Any time soon for this package to be in distribute for noetic as ros package?

HappySamuel commented 3 years ago

@Tobias-Fischer

How do you get it work on Noetic with src? I managed to catkin_make successfully with the src, but when i run the program, it crashed.

Screenshot from 2021-02-15 14-27-27

Best, Samuel

Tobias-Fischer commented 3 years ago

Hi @HappySamuel - it's impossible to tell from the screenshot. As the error message says, the serial port is already open. This seems more like a bug in the downstream code? I didn't need to modify anything in the code that I am using (um7).

lauralindzey commented 3 years ago

@wjwwood bump =)

Tobias-Fischer commented 3 years ago

Ping @wjwwood

HappySamuel commented 3 years ago

Hi @Tobias-Fischer

I found the root cause of that issue. It's because of my another package that caused the problem, they interfere each other if they're catkin_make under same workspace. If separated them into different workspace, and linked together, this issue will not persist. Previously on Ubuntu 16.04 and 18.04, i didn't face this issue, it's because i installed the serial package using sudo apt-get install, hence it's in different workspace (/opt/ros/version/...). Due to yet to have distribute version of serial package in ros noetic, this is the solution i applied.

Hope, there'll soon release noetic version of serial package. @wjwwood

Best, Samuel

HappySamuel commented 3 years ago

Still waiting for noetic release...

tkazik commented 2 years ago

There was a plan to create a new release a few months ago, see https://github.com/wjwwood/serial/issues/240#issuecomment-859121214 @wjwwood, how could we help?

SubaruArai commented 2 years ago

If there is nobody doing it, I can make a pr to ros/rosdistro. @wjwwood can I make a pr to rosdistro/noetic?

SubaruArai commented 2 years ago

@wjwwood I made a draft pr. If you think it's fine, please accept. https://github.com/ros/rosdistro/pull/31386

wjwwood commented 2 years ago

I had to close it, I don't think you used bloom to release the repository, which is required. I was wanting to switch to pure CMake, away from catkin, and to do that I needed to fix CI with GitHub Actions, and so on and so forth. I haven't had time to do that, so I'll just release it as-is.

wjwwood commented 2 years ago

https://github.com/ros/rosdistro/pull/31420 this will get merged soon prob

SubaruArai commented 2 years ago

@wjwwood My bad, thank you!