Merging CMAKE changes - Githubissues

wjwwood / serial

Cross-platform, Serial Port library written in C++

http://wjwwood.github.com/serial/

MIT License

2.11k stars 1.03k forks source link

Merging CMAKE changes #252

Closed Cazadorro closed 3 years ago

Cazadorro commented 3 years ago

@wjwwood Is it possible to have this merged? Our team currently relies on this change to even use this library, since we don't use Catkin at all. With out this we essentially have to maintain our own fork of this library until you do.

wjwwood commented 3 years ago

I'm not planning on merging that, sorry. I would recommend you maintain your own fork for now.

There have been numerous similar pull requests/issues in the past. I will be moving away from catkin in the future, but I'll do that in the next major release. I don't know when I'll get to it, but I'll probably roll my own set of changes for updating to pure CMake.

wjwwood commented 3 years ago

I appreciate you opening the pull request though (even if you close it after my update), it might be useful to others in the meantime.