What:
Add Data-Terminal-Ready (DTR) control parameter to the Serial constructor.
Why:
To set the default in the constructor. The arduino IDE and pyserial lib both provide constructor arguments for setting the default DTR behaviour of a serial object without needing to make external calls to update the properties of a file handle after construction. This is desirable behaviour.
Solves #265
How:
Create a dtrcontrol_t enum with values dtr_disable, dtr_enable, and dtr_handshake.
dtr_handshake is non-functional.
Add dtrcontrol_t dtrcontrol_ field to SerialImpl.
Replace Serial::setDTR() and SerialImpl::setDTR() bool parameters with dtrcontrol_t parameters.
Set SerialImpl::dtrcontrol_ to parameter value of SerialImpl::setDTR() in SerialImpl::setDTR().
Configure DTR within SerialImpl::reconfigurePort() depending on the value of SerialImpl::dtrcontrol_.
Add dtrcontrol_t constructor arguments for both Serial and SerialImpl constructors.
The default Serial constructor parameter value of dtrcontrol_t is dtr_disable.
These changes are made to both windows and unix implementations.
If something is not satisfactory, please let me know and I will make adjustments.
- Maxine
What: Add Data-Terminal-Ready (DTR) control parameter to the Serial constructor.
Why: To set the default in the constructor. The arduino IDE and pyserial lib both provide constructor arguments for setting the default DTR behaviour of a serial object without needing to make external calls to update the properties of a file handle after construction. This is desirable behaviour.
Solves #265
How:
dtrcontrol_tenum with valuesdtr_disable,dtr_enable, anddtr_handshake.dtr_handshakeis non-functional.dtrcontrol_t dtrcontrol_field toSerialImpl.Serial::setDTR()andSerialImpl::setDTR()bool parameters withdtrcontrol_tparameters.SerialImpl::dtrcontrol_to parameter value ofSerialImpl::setDTR()inSerialImpl::setDTR().SerialImpl::reconfigurePort()depending on the value ofSerialImpl::dtrcontrol_.dtrcontrol_tconstructor arguments for bothSerialandSerialImplconstructors.Serialconstructor parameter value ofdtrcontrol_tisdtr_disable.These changes are made to both windows and unix implementations.
If something is not satisfactory, please let me know and I will make adjustments. - Maxine