Enhance quality of this cookbook

[rmoriz]

Thanks for the cookbook. Please consider the following enhancements:

• add test-kitchen support https://github.com/test-kitchen/test-kitchen
• add tests for the LWRP (e.g. test-kitchen + fixture cookbook + serverspec)
• use Rubocop to adopt the common Ruby styleguide https://github.com/bbatsov/rubocop
• use Foodcritic to adopt the common Chef cookbook styleguide. http://acrmp.github.io/foodcritic/
• add a Rakefile to automate the tests
• add Travis CI to test each commit
• change license to a a popular and OSI accepted open source license http://opensource.org/licenses

Thanks!

[wk8]

Hi @rmoriz ,

Thanks for the feedback!

I'm fully aware of this cookbook's poor quality, as it happens, and I've been wanting to add TK tests for a looong time, but never had the time to do so. Just wrote it to do the job when I needed it, but never had the time to bring it up to par with usual standards.

If you use this cookbook, maybe you'll want to open a few PRs to address some of the issues you highlight above? :-)

[rmoriz]

@wk8 I can do that, but the current licensing is a show-stopper for me.

[wk8]

If you make a PR to change it to MIT (bumping the version, since the current version's license can't be modified), I'll merge it.

That being said, why is the licensing such a big deal to you, if you don't mind me asking?

[rmoriz]

@wk8 Isn't OpenSource about an open license? When I contribute to a project, I want to be able to use my contribution. I trust in OSI's analysis of various licenses. Almost all chef cookbooks are Apache licensed, most Ruby gems are MIT-licensed. Both do the job very good IMHO.

[wk8]

@rmoriz sure is; but seemed to me the current licensing's even more permissive, so I was wondering what's so wrong with it in your opinion.

In any case, happy to change to MIT, as stated above.