search

wkaisertexas / ScreenTimeLapse

Take color-accurate timelapses of your screens and cameras on MacOS
https://apps.apple.com/us/app/timelapze/id6473860445
MIT License
778 stars 25 forks source link

Doing a better job of localization #42

Closed wkaisertexas closed 2 months ago

wkaisertexas commented 4 months ago

I did a really sloppy job of localization the first time and the string catalog has erronious pieces of text. I should really clarify that no additional information should be present.

Furthermore, it may be a good idea to add some checks. For example, @lld must match a @lld in the output file to have the string template work properly.

Finally, a InfoPlist.xcstrings file should be added to extract and translate the strings which were found in this file.

--

p.s. this is kind of embarrassing how little effort I gave to localization despite writing tranzlate.js. Once I wrote this, I kind of thought it was automatic and spent less than a minute actually using it.

wkaisertexas commented 3 months ago

https://github.com/wkaisertexas/ScreenTimeLapse/blob/023f85982a8cd37378d166a96c3864d9931f8d12/TimeLapze/Utils.swift#L33C1-L48C2

Is not a localized string, so you end up getting Low, Medium and High no matter the language