footprint shrink a bit - Githubissues

wkaster / N76E003

Nuvoton N76E003 with SDCC

31 stars 14 forks source link

footprint shrink a bit #3

Closed kimstik closed 2 years ago

kimstik commented 2 years ago

footprint is 727 bytes (instead of 1389 from last iteration) get rid of useless runtime 32bit divisions FIXME: makefile was screwed for non-bootloader apps TODO: lets pack to 512?

wkaster commented 2 years ago

Very Nice! I'll test this branch before merge. Thinking about create a "standalone" option in the makefile to supress the lib directory if needed.

wkaster commented 2 years ago

Bug: Not receiving the CMD_ACK after software reset request (CMD_EOT), dont know why. Aparently handshake is ok, flash program is ok. Tested with 2 SDCC versions: 3.91 footprint 754 4.1 footprint 723

wkaster commented 2 years ago

Bug found: tx function not sending the ACK before software reset. "while(TI==0);" should go to the last line.

kimstik commented 2 years ago

I believe that "while(TI==0);" placed correctly This way is more correct and secure. Plus it gives better performance.

kimstik commented 2 years ago

May you test last one before merging?

wkaster commented 2 years ago

I believe that "while(TI==0);" placed correctly This way is more correct and secure. Plus it gives better performance.

Yes, your way is better.

wkaster commented 2 years ago

May you test last one before merging?

Of course, Do you mind if I add your name to the source header as co-author?

wkaster commented 2 years ago

Could not make those last 2 commits to work. They simply don't boot. (SDCC 4.1)

kimstik commented 2 years ago

Could not make those last 2 commits to work. They simply don't boot. (SDCC 4.1)

Really? No any answer for CMD_SOH ? I see that erase screwed in last commit. is 4ff1bf4 commit works?

wkaster commented 2 years ago

Last working version: [7bfc15f] WHITOUT the modified peep file. I'll do some more testing as soon as possible.

kimstik commented 2 years ago

Of course, Do you mind if I add your name to the source header as co-author?

I hesitate to change the header. You can add me as a contributor.

wkaster commented 2 years ago

Of course, Do you mind if I add your name to the source header as co-author?

I hesitate to change the header. You can add me as a contributor.

In my mind, with the work you have done so far, this bootloader is much yours as it is mine. Please, feel free to change the header as you see fit.