Open joa-quim opened 8 years ago
what happens if you do aliases=["gdal","gdal111","gdal201","gdal_w32","gdal_w64"]
instead?
Also, why is this a different PR from #20?
what happens if you do aliases=["gdal","gdal111","gdal201","gdal_w32","gdal_w64"] instead?
Not sure. It may work as well, "gdal_w32" is the 32 bits version of the same dll
Also, why is this a different PR from #20?
Well, it was you who asked me to change build.jl
instead. This is intended to replace #20
Oh, you could have made the changes to #20 directly, since it's under the same umbrella issue of updating the build script. I don't mean to patronize; just trying to understand the intent of this PR.
Not sure. It may work as well, "gdal_w32" is the 32 bits version of the same dll
If it works, I think it'll be preferable to stick to just expanding the list of aliases.
Ok, I thought that since this change a different file I should do another PR.
And regarding the aliases, what I can say is that for me it works as well to have only
libgdal = library_dependency("libgdal",aliases=["gdal","gdal111","gdal201","gdal_w64","gdal_w32"])
ah, and btw, I don't know how to change an existing PR, only to make anew one.
LGTM
ah, and btw, I don't know how to change an existing PR, only to make anew one.
I've found the tutorials by atlassian pretty helpful when starting out:
Given that we're pretty strapped to github (+travis+appveyor) in our infrastructural support, it'll be good to spend some time to learn them well for future PRs. Let us know if we can help walk you through any of it.
Add names of the GDAL DLL as currently in http://www.gisinternals.com and the GMT installer