wkeese / old-api-viewer

Old viewer for output of old js-doc-parse, replaced by https://github.com/dojo/dapi
22 stars 10 forks source link

subtle bugs with "private" and "inherited" buttons #23

Closed wkeese closed 12 years ago

wkeese commented 12 years ago

Toggling on private properties (and methods) will display private methods from inherited classes even if the "inherited" button is toggled off. For example, on the dijit.Menu page, hide both privates and inherited's, then show privates, and _attachEvents will show up even though it's supposed to be hidden because it's inherited.

Also, there is shading for alternate rows of the "property summary" and "method summary" tables, but the shading only works correctly when all the rows are displayed. When some rows are hidden you can theoretically get contiguous gray rows or contiguous white rows.

The way we are doing shading now can be more easily acheived via a CSS :nth-child(odd) selector, although that will have the same problem as above. The accurate way to do it will be to recompute odd/even depending on which rows are shown and hidden.