search

wkentaro / chainer-mask-rcnn

Chainer Implementation of Mask R-CNN. (Training code to reproduce the original result is available.)
MIT License
55 stars 16 forks source link

use scikit-image >= 0.11.0 for default and check scikit-image version #36

Closed knorth55 closed 5 years ago

knorth55 commented 5 years ago

because of find_boundaries(lbl, connectivity)

knorth55 commented 5 years ago

check scikit-image version for system python-skimage (0.10.1 for ubuntu16.04)

wkentaro commented 5 years ago

What happens without connectivity in the latest one? I think I may be fine removing connectivity arg completely.

wkentaro commented 5 years ago

But this looks already fine. So I’ll merge this. Thanks.

knorth55 commented 5 years ago

This error occurs

[ERROR] [1555064716.944284]: bad callback: <bound method MaskRCNNInstanceSegmentation.callback of <__main__.MaskRCNNInstanceSegmentation object at 0x7f2b7f6306d0>>
Traceback (most recent call last):
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/rospy/topics.py", line 750, in _invoke_callback
    cb(msg)
  File "/home/chou/ros/jsk_ros_pkg_ws/src/jsk_recognition/jsk_perception/node_scripts/mask_rcnn_instance_segmentation.py", line 143, in callback
    masks=masks, captions=captions)
  File "/usr/local/lib/python2.7/dist-packages/chainer_mask_rcnn/utils/visualizations.py", line 74, in draw_instance_bboxes
    mask_inst, connectivity=2)
TypeError: find_boundaries() got an unexpected keyword argument 'connectivity'

[ERROR] [1555064717.154081]: bad callback: <bound method MaskRCNNInstanceSegmentation.callback of <__main__.MaskRCNNInstanceSegmentation object at 0x7f2b7f6306d0>>
Traceback (most recent call last):
  File "/opt/ros/kinetic/lib/python2.7/dist-packages/rospy/topics.py", line 750, in _invoke_callback
    cb(msg)
  File "/home/chou/ros/jsk_ros_pkg_ws/src/jsk_recognition/jsk_perception/node_scripts/mask_rcnn_instance_segmentation.py", line 143, in callback
    masks=masks, captions=captions)
  File "/usr/local/lib/python2.7/dist-packages/chainer_mask_rcnn/utils/visualizations.py", line 74, in draw_instance_bboxes
    mask_inst, connectivity=2)
TypeError: find_boundaries() got an unexpected keyword argument 'connectivity'
wkentaro commented 5 years ago

I meant removing that argument from code. But that’s fine.

wkentaro commented 5 years ago

You need a release, right?

wkentaro commented 5 years ago

Please upgrade chainer-mask-rcnn to 0.5.19.