search

wkentaro / gdown

Google Drive Public File Downloader when Curl/Wget Fails
MIT License
4.16k stars 345 forks source link

Fixing download_folder in windows using pathlib.Path #128

Closed rjanuzi closed 2 years ago

rjanuzi commented 2 years ago

Hey @wkentaro a simple fix to the problem in windows machines (#109), you could be migrate the filesystem management to use pathlib.Path , its simpler and parses correctly across the SOs.

I've simply mixed the code with Path inside the download_folder function, but it will be cleaner if migrate all the code.

Working on windows sample

Regards,

wkentaro commented 2 years ago

It doesn’t fix #109, because you only change download_folder, isn’t it?

rjanuzi commented 2 years ago

It doesn’t fix #109, because you only change download_folder, isn’t it?

Yes @wkentaro its not a fix, its just an idea validated in the context of "download_folder". I've changed the code in my local workspace in order to use in windows. I would like to propose the full implementation, but I'll not be able to do right now.

Regards,