wkentaro / gdown

Google Drive Public File Downloader when Curl/Wget Fails
MIT License
4.16k stars 345 forks source link

Regression in version 4.2.1. Downloads do not work anymore under Windows #153

Closed Deflaktor closed 2 years ago

Deflaktor commented 2 years ago

The exact error message is: [WinError 32] The process cannot access the file because it is being used by another process

grafik

After the exception has been thrown, I still have the file downloaded on my file system (download was 100% successful, no corruption on the file). Not only the downloaded file, but I also have a copy of it with the name BGM.zip6vhvh0tmp.

Furthermore, if a start up a debugger and add a breakpoint to line 253 and let python close the file (run just a single step), I still cannot move or rename the downloaded file with windows explorer as it also will give me a permission denied error as the file is in use by another process.

Im not exactly sure why this error happens. Mac users didnt have this issue, only Windows users. It has been working with 4.2.0.

wkentaro commented 2 years ago

Can you try with Gdown==4.2.1 as well?

Deflaktor commented 2 years ago

with 4.2.1 the error is happening as well

wkentaro commented 2 years ago

Can you try the version in https://github.com/wkentaro/gdown/pull/154?

pip install git+https://github.com/wkentaro/gdown@hotfix/windows
Deflaktor commented 2 years ago

yep that one worked

wkentaro commented 2 years ago

Thank you for the report and confirmation! I'll merge and release as v4.3.1 soon!

wkentaro commented 2 years ago

Done! https://github.com/wkentaro/gdown/releases/tag/v4.3.1 🎉

Deflaktor commented 2 years ago

thank you very much!