Adapt gdown to be used as python library

wkentaro / gdown

Google Drive Public File Downloader when Curl/Wget Fails

MIT License

4.06k stars 342 forks source link

Open Skitionek opened 1 year ago

Skitionek commented 1 year ago

[x] Exceptions are printed only on cli (otherwise simply raised)
[x] Allows for custom progress callbacks (which defaults to old behaviour)
[x] stderr stands for "standard error" - progress messages should be printed to stdin

wkentaro commented 1 year ago

The change to Exception looks good, but I'm not sure about others. If you split PRs, we can merge some of them earlier.

wkentaro commented 1 year ago

Regarding stderr vs stdout, this is the reason why we keep stderr for the log messages.

Skitionek commented 1 year ago

Regarding stderr vs stdout, this is the reason why we keep stderr for the log messages.

Interesting, yet putting flag --quiet should silence all progress prints from code.... Therefore it still can be used the way you mentioned.

Skitionek commented 1 year ago

The change to Exception looks good, but I'm not sure about others. If you split PRs, we can merge some of them earlier.