Feature: allow folders to be continued more usefully

wkentaro / gdown

Google Drive Public File Downloader when Curl/Wget Fails

MIT License

4.06k stars 342 forks source link

Feature: allow folders to be continued more usefully #288

Closed achadwick closed 2 months ago

achadwick commented 7 months ago

The --continue option can now be used with folders.
When a download is being sent to a file, detect when the file to resume is complete (→ has its final name)
- Avoids 0-byte ranged transfers (which still count against the shared folder's download limit!)
- Speeds up --continue (resume mode) for partially transferred folders containing lots of files.
- Especially useful when download allowances are very limited, e.g. Tor-proxied access, or very popular folders.
Now uses the conventional .part suffix for tempfiles, to make life nicer with Linux desktop thumbnailers.
Update command line arguments to match.

achadwick commented 4 months ago

Apologies for the forced push. @wkentaro, any chance you could merge these now, or is there anything more you'd like to see? I've adapted the patch to your move of cli.py to __main__.py, and worked my new folder-mode --continue/resume handling in around the internal-only skip_download flag you introduced - Skip Download mode has priority.

Happy to review and update it to match your requirements.

melMass commented 4 months ago

Yes please consider this, I run a fork just for this reason. I just had to update my fork after an issue popped up

ryukinix commented 3 months ago

Just a random feedback: this feature is very useful. I'll install the fork one to have this.

wkentaro commented 2 months ago

@achadwick Looks really useful. Thank you for the contribution!