search

wkentaro / gdown

Google Drive Public File Downloader when Curl/Wget Fails
MIT License
4.33k stars 350 forks source link

Feature: Add a regex filename filter #310

Closed o-laurent closed 9 months ago

o-laurent commented 10 months ago

Hi @wkentaro,

I followed the directions that you provided in our discussion.

I remain available for any questions or updates.

This PR depends on #308.

o-laurent commented 10 months ago

Another possibility would be to use something like https://docs.python.org/3/library/fnmatch.html that may be closer to what you expect of the behavior of a ".gitignore".

wkentaro commented 9 months ago

@o-laurent Looking good, thanks. Btw, do you need the command line option?

o-laurent commented 9 months ago

@o-laurent Looking good, thanks. Btw, do you need the command line option?

@wkentaro, I won't need the CLI option. Of course, feel free to remove it if you think that your lib would be better without/it is not necessary.

By the way, I just pulled your changes from #308. This PR also fixes a lint issue.

wkentaro commented 9 months ago

@o-laurent I think https://github.com/wkentaro/gdown/pull/317 is more simple yet flexible. Please check it out.

o-laurent commented 9 months ago

Simpler, I'd say that it depends on the use case, but more flexible, definitely. It will solve my problem nicely. Thanks @wkentaro for your help!