Fix tests for Windows - Githubissues

RunDevelopment commented 5 months ago

Fixes #313.

Changes:

Removed all uses of shlex.split. Since windows paths use \, string interpolation + shlex.split will result in those backslashes being interpreted as escape sequences. So I used argument arrays everywhere instead.
Removed the assumption that /tmp is a directory that exists.
Removed usage of tempfile.NamedTemporaryFile(). The named file is opened by the test process, which means that it cannot be written to by a sub process on windows.
Added GH CI job for tests with Windows test runner. Since make doesn't exist on Windows, I copied the test command.

RunDevelopment commented 5 months ago

Right now, all tests pass on Windows except for test_download_folder_from_gdrive. I have no idea what this command does, so I can't replace it with equivalent python code.

wkentaro commented 4 months ago

@RunDevelopment Now I added CI for Windows that uses make command with : https://github.com/wkentaro/gdown/pull/324

I'll work on updating the tests next.

wkentaro / gdown

Fix tests for Windows #320