search

wkentaro / gdown

Google Drive Public File Downloader when Curl/Wget Fails
MIT License
4.29k stars 350 forks source link

Refactory download and create get_url function #96

Closed guissalustiano closed 3 years ago

guissalustiano commented 3 years ago

I need download using tfds.download.DownloadManager from Tensorflow, to this I only need the download url.

Does it make sense to add this to the download.py file? Only need to refactor the download function to smaller functions. I can do this, but need confirmation that is ok.

wkentaro commented 3 years ago

I guess you can create your small function in your local module?

guissalustiano commented 3 years ago

Of course, it's a simple function. I just commented here because it is a logic that already exists in this package and could be made available to other people with similar problems.

wkentaro commented 3 years ago

So do you think it is a common issue for people who use tensorflow?

wkentaro commented 3 years ago

I don't use Tensorflow and its DownloadManager, so not sure how useful it is, but if the refactoring result is not too complex and acceptable, I'll probably merge it.

guissalustiano commented 3 years ago

Honestly, coming to think of it, it's a very specific case that I used, most people usually host these files on s3 which makes it easier to download I'll close this for now and if anyone else is interested I can implement