wkentaro / labelme

Image Polygonal Annotation with Python (polygon, rectangle, circle, line, point and image-level flag annotation).
https://labelme.io
Other
13.62k stars 3.42k forks source link

pip install error on other language Windows #1509

Open ladofa opened 3 weeks ago

ladofa commented 3 weeks ago

Provide environment information

conda of python 3.12.4

What OS are you using?

Windows 10 (Korean)

Describe the Bug

pip install labelme -> doesn't work on Korean Windows 10/11

Expected Behavior

The reason comes from setup.py open() function. Korean python uses cp949 encoding in default. open of line 14 and 73 should be have encoding='utf-8' option.

To Reproduce

No response

YejinHwang909 commented 1 week ago

@ladofa can you modify setup.py?

def get_long_description():
    with open("README.md", encoding="utf-8") as f:
        long_description = f.read()

It works for me.

ladofa commented 1 week ago

@ladofa can you modify setup.py?

def get_long_description():
    with open("README.md", encoding="utf-8") as f:
        long_description = f.read()

It works for me.

yeah i already did it for me, i am asking for

pip install labelme 😉

YejinHwang909 commented 1 week ago

@ladofa How about going to the labelme folder and running the pip install . command?

ladofa commented 1 week ago

@ladofa How about going to the labelme folder and running the pip install . command?

Thank you for your kind reply. I already knew how to solve.

I'm asking for my students and all people, not to you YejinWhang, but to the developer wkentaro. Please fix it.