search

wkentdag / spike-wordpress

wordpress plugin for spike
https://www.npmjs.com/package/spike-wordpress
Other
8 stars 0 forks source link

fix typo in readme #84

Closed datesss closed 7 years ago

datesss commented 7 years ago

Started messing around with spike today after learning about it at a meetup. Noticed in your readme the package name needs to be capitalized 👍 excited to play with this.

wkentdag commented 7 years ago

Whoops, thanks for catching this! I'm not sure why the tests are failing, I'll investigate and merge this in ASAP, probably tomorrow afternoon or Saturday morning

datesss commented 7 years ago

ah! I pushed to my own repo which I didn't realize would affect this Pull Request, because I'm kindof new to github.

I was frustrated because when using the templates, the {{ item }} wasn't available as a variable on the pages for whatever reason, when compiling. What I did was take code from the spike-rooftop repository/plugin, and added the wpapi node package. I basically just did it so i could get it working. A single request is still limited to 100 posts with wp-api, but adding more wordpress integration/features might be nice/easier using that package. altho dependencies.... also i thought it might be nice if there was a lil consistency between different cms plugins.... Not expecting you to merge this but take a look if you wanna! Would be happy to test more / update documentation / help / make an actual PR if you're interested in going that way.

Anyways, Thanks for getting back to me! B-) No rush at all updating, I'm only playing around with this for fun, its not on production or anything :-)

wkentdag commented 7 years ago

Ok, so I've fixed the typo in the readme - thanks for pointing that out.

I did base this package off of spike-rooftop so I guess it would be cool for the code to match more 1:1. However, this PR also involves upgrading from the wp-api v1 to v2. I already have an open issue #11 addressing this update but it's been on the backburner for me since I haven't needed to upgrade yet. If you wouldn't mind re-submitting your PR with a more descriptive name and updates to the README, I'm happy to merge it in. Thanks!